-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immersed boundary condition instead of forcing #130
Conversation
Co-authored-by: Gregory L. Wagner <wagner.greg@gmail.com>
Co-authored-by: Gregory L. Wagner <wagner.greg@gmail.com>
Co-authored-by: Gregory L. Wagner <wagner.greg@gmail.com>
Co-authored-by: Gregory L. Wagner <wagner.greg@gmail.com>
…nto ss/omip-simulation
…jl into ss/omip-with-restoring
Why would it be different? If its different there's a bug. We should also add a test to check for this this specifically in Oceananigans, since it has been discovered / is believed to be possible here. |
The results here should tell us if this method works. A test in Oceananigans should definitely be added because it looks like this is untested |
Why do you think it is possible they are different? Have you seen this before? Is there another example where this occurred? |
I remember some time ago there was a problem with this method, but I would have to go back to look at what issue it was.
|
We shouldn't have to use such caution, because the code should not have so many bugs that things are so delicate. Can we figure out what the issue is? I don't think |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 31 31
Lines 1740 1742 +2
=====================================
- Misses 1740 1742 +2 ☔ View full report in Codecov by Sentry. |
Maximum velocity seems to be equal between this PR and the documentation one https://clima.github.io/ClimaOceanDocumentation/previews/PR104/literated/near_global_ocean_simulation/ |
This PR lists 29 files changed but the title just states that bottom drag was implemented with |
because we have to merge the documentation PR |
|
||
u_immersed_bc = ImmersedBoundaryCondition(bottom = u_immersed_drag) | ||
v_immersed_bc = ImmersedBoundaryCondition(bottom = v_immersed_drag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only change I expected to see
There are 783 commits on this PR |
Then put this PR to merge into that PR, not |
oops too late, I ve merged the documentation PR |
Still 784 commits here. Maybe open a new PR with just the changes needed here? |
@navidcy any idea why the preview for this isn't showing? Or where it might be? |
Closed in favor of the new PR |
delete the branch? |
To be merged only if the near-global example works with reasonable velocities
closes #128